Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli compression options and jsc serealizer #147

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Brotli compression options and jsc serealizer #147

merged 5 commits into from
Aug 26, 2024

Conversation

Mrgaton
Copy link
Member

@Mrgaton Mrgaton commented Jul 30, 2024

No probe absolutamente nada de estos cambios.

@Mrgaton
Copy link
Member Author

Mrgaton commented Jul 31, 2024

Closes #145 and #146

@Mrgaton Mrgaton marked this pull request as ready for review August 1, 2024 09:34
@Mrgaton
Copy link
Member Author

Mrgaton commented Aug 1, 2024

Creo estaria bien mirar el primer kb del buffer a comprimir para determinar si es texto o no y especificar el modo generico o el especifico para texto.

@inetol inetol added the ack:not-ready Do NOT merge yet label Aug 1, 2024
Copy link
Contributor

@inetol inetol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El cambio de CBOR a la implementación de JSC romperá los documentos existentes, por lo que quiero esperar al PR de la base de datos

@Mrgaton
Copy link
Member Author

Mrgaton commented Aug 1, 2024

Si es verdad justo lo pense hace nada, perdon

@inetol inetol removed the ack:not-ready Do NOT merge yet label Aug 26, 2024
Copy link
Contributor

@inetol inetol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

El serializer de JSC seguramente ya no haga falta una vez este la base de datos, pero lo mantengo por si hay algún imprevisto

@inetol inetol merged commit cdf9abd into db Aug 26, 2024
1 check passed
@inetol inetol deleted the jsc-&-brotli branch August 26, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialización con JavaScriptCore
2 participants